<html><head></head><body>Hi,<br><br>i have just send v2 of the lmtp patch (3 parts).<br><br>All your comments should now be adressed.<br>In my testing environment it works perfectly.<br><br>But i can´t successfully build the pmg-docs package, but i think this was the easiest patch.<br><br>Could you please check the v2 version and give me some feedback?<br><br>I think it could be ready for pmg-test repository.<br><br>The CLA is in the road ;)<br><br>Thank you,<br>Julian<br><br><div class="gmail_quote">Am 13. Dezember 2019 09:22:33 MEZ schrieb Stoiko Ivanov <s.ivanov@proxmox.com>:<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<pre class="k9mail">Hi,<br><br>On Thu, 12 Dec 2019 22:18:23 +0100<br>Julian Zehnter <pmg-devel@j-z.it> wrote:<br><br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #729fcf; padding-left: 1ex;">Hi,<br><br>thank you for your feedback, review and testing.<br><br>I will put your feedback on the individual patches in a new v2 patch<br>and will test it on my mailgate-dev according your suggestion.<br><br>i will come back in the next days with v2.<br></blockquote><br>Perfect - Looking forward!<br><br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #729fcf; padding-left: 1ex;"><br>Regards,<br>Julian<br></blockquote><br><br>Thank you and best Regards,<br>stoiko<br><br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #729fcf; padding-left: 1ex;"><br>Am 10.12.2019 um 11:19 schrieb Stoiko Ivanov:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #ad7fa8; padding-left: 1ex;"> Hi,<br><br> Thank you very much for your contribution!<br><br><br> On Mon, 9 Dec 2019 20:59:55 +0100<br> Julian Zehnter <pmg-devel@j-z.it> wrote:<br> <br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #8ae234; padding-left: 1ex;"> Hi,<br><br> this is my first trial to implement the lmtp support in bugzilla #2438.<br> I just dive into the code an adapt some parts for lmtp.<br><br> Mybe you can check the examine the patches and give me some hints of missing parts.<br> How can i check the changes in a test environment? <br></blockquote> We gave them a quick look - noticed to small glitches (I'll point them<br> out in reply to the individual patches).<br><br> We'd still need a signed CLA to be able to apply it, see:<br> <a href="https://pve.proxmox.com/wiki/Developer_Documentation#Software_License_and_Copyright">https://pve.proxmox.com/wiki/Developer_Documentation#Software_License_and_Copyright</a><br> for details.<br><br> I'll apply and test them locally and provide some feedback here - maybe you could<br> wait with a v2.<br> <br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #8ae234; padding-left: 1ex;">The perl files seems to be easily to replace. <br></blockquote>You can edit them inplace (or run `make deb`; and install the .deb package afterwards)<br>Afterwards you'd need to restart the affected services (pmgproxy, pmgdaemon) and<br>run pmgconfig sync (in this case).<br> <br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #8ae234; padding-left: 1ex;">Regarding the js files, i don´t know. <br></blockquote> Probably again the easiest is to run `make deb` and install the pmg-gui package<br> running make install as root in the top-directory (however this might leave your<br> system in a rather odd state (until a package upgrade overrides it)<br> I personally always use the deb route for the GUI.<br><br> <br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #8ae234; padding-left: 1ex;">Thanks und Greetings,<br>Julian <br></blockquote> Thank you!<br> stoiko<br><br> <br></blockquote><br></blockquote><br><br><br></pre></blockquote></div></body></html>