<html><head></head><body>Hi,<br><br>thank you for the feedback here and at the individual patches.<br><br>I will put your comments in a new commit it in the next few days, at the latest next weekend.<br><br>Sorry for the unintended whitespaces and <br>indentation level. It seems vscode made here some unvisible foo. I will check that.<br><br>Thank you and regards, <br>Julian<br>-- <br>Julian Zehnter - j-z.IT<br>An den Linden 47<br>97230 Estenfeld<br><br>E-Mail: mail@creative-www.de<br><br><br><div class="gmail_quote">Am 8. Januar 2020 19:57:43 MEZ schrieb Stoiko Ivanov <s.ivanov@proxmox.com>:<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<pre class="k9mail">Hi,<br><br>sorry for the long wait for feedback!<br><br>On Sun, 05 Jan 2020 22:07:35 +0100<br>pmg-devel@j-z.it wrote:<br><br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #729fcf; padding-left: 1ex;">Hi,<br><br>i have just send v2 of the lmtp patch (3 parts).<br><br>All your comments should now be adressed.<br>In my testing environment it works perfectly.<br></blockquote><br>I quickly gave it a spin here, by setting up a dovecot in my test environment<br>and setting that as default relay and as a transport for a particular domain<br><br>It does work quite nicely!<br>Huge thanks for your time and effort!<br><br>I did find a few cosmetic nits (will write them as replies to the <br>individual patches) - but I think we could address them as fixups<br>following your commits.<br><br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #729fcf; padding-left: 1ex;"><br>But i can´t successfully build the pmg-docs package, but i think this was the easiest patch.<br></blockquote>Content-wise it looks good - the trick would have been to:<br>* patching pmg-api<br>* patching pmg-docs/gen-pmg.conf.5-opts.pl (adding the relayprotocol key)<br>* copying it to /usr/share/pmg-doc-generator/gen-pmg.conf.5-opts.pl<br>* build pmg-api and install the resulting deb<br>* running `make update` inside the pmg-docs repo (this generates the updated<br> 'pmg.mail-relaying-conf-opts.adoc' and 'pmg.conf.5-opts.adoc'<br>* adapting the remaining documentation ('pmgconfig.adoc')<br>* building and installing pmg-docs and pmg-doc-generator<br><br>which is quite the long procedure - and something we can do here (until<br>we come up with a nicer interface)<br><br><br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #729fcf; padding-left: 1ex;"><br>Could you please check the v2 version and give me some feedback?<br><br>I think it could be ready for pmg-test repository.<br><br>The CLA is in the road ;)<br></blockquote>Thanks - AFAIK we received it by now!<br><br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #729fcf; padding-left: 1ex;"><br>Thank you,<br>Julian<br><br>Am 13. Dezember 2019 09:22:33 MEZ schrieb Stoiko Ivanov <s.ivanov@proxmox.com>:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #ad7fa8; padding-left: 1ex;">Hi,<br><br>On Thu, 12 Dec 2019 22:18:23 +0100<br>Julian Zehnter <pmg-devel@j-z.it> wrote:<br> <br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #8ae234; padding-left: 1ex;">Hi,<br><br>thank you for your feedback, review and testing.<br><br>I will put your feedback on the individual patches in a new v2 patch<br>and will test it on my mailgate-dev according your suggestion.<br><br>i will come back in the next days with v2. <br></blockquote><br>Perfect - Looking forward!<br> <br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #8ae234; padding-left: 1ex;"><br>Regards,<br>Julian <br></blockquote><br><br>Thank you and best Regards,<br>stoiko<br> <br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #8ae234; padding-left: 1ex;"><br>Am 10.12.2019 um 11:19 schrieb Stoiko Ivanov: <br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #fcaf3e; padding-left: 1ex;"> Hi,<br><br> Thank you very much for your contribution!<br><br><br> On Mon, 9 Dec 2019 20:59:55 +0100<br> Julian Zehnter <pmg-devel@j-z.it> wrote:<br> <br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #e9b96e; padding-left: 1ex;"> Hi,<br><br> this is my first trial to implement the lmtp support in bugzilla <br></blockquote></blockquote></blockquote>#2438. <br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #8ae234; padding-left: 1ex;"><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #fcaf3e; padding-left: 1ex;"><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #e9b96e; padding-left: 1ex;"> I just dive into the code an adapt some parts for lmtp.<br><br> Mybe you can check the examine the patches and give me some hints <br></blockquote></blockquote></blockquote>of missing parts. <br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #8ae234; padding-left: 1ex;"><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #fcaf3e; padding-left: 1ex;"><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #e9b96e; padding-left: 1ex;">How can i check the changes in a test environment? <br></blockquote>We gave them a quick look - noticed to small glitches (I'll point <br></blockquote></blockquote>them <br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #8ae234; padding-left: 1ex;"><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #fcaf3e; padding-left: 1ex;"> out in reply to the individual patches).<br><br> We'd still need a signed CLA to be able to apply it, see:<br> <br></blockquote></blockquote><a href="https://pve.proxmox.com/wiki/Developer_Documentation#Software_License_and_Copyright">https://pve.proxmox.com/wiki/Developer_Documentation#Software_License_and_Copyright</a> <br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #8ae234; padding-left: 1ex;"><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #fcaf3e; padding-left: 1ex;"> for details.<br><br> I'll apply and test them locally and provide some feedback here - <br></blockquote></blockquote>maybe you could <br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #8ae234; padding-left: 1ex;"><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #fcaf3e; padding-left: 1ex;">wait with a v2.<br> <br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #e9b96e; padding-left: 1ex;">The perl files seems to be easily to replace. <br></blockquote>You can edit them inplace (or run `make deb`; and install the .deb <br></blockquote></blockquote>package afterwards) <br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #8ae234; padding-left: 1ex;"><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #fcaf3e; padding-left: 1ex;">Afterwards you'd need to restart the affected services (pmgproxy, <br></blockquote></blockquote>pmgdaemon) and <br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #8ae234; padding-left: 1ex;"><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #fcaf3e; padding-left: 1ex;">run pmgconfig sync (in this case).<br> <br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #e9b96e; padding-left: 1ex;">Regarding the js files, i don´t know. <br></blockquote>Probably again the easiest is to run `make deb` and install the <br></blockquote></blockquote>pmg-gui package <br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #8ae234; padding-left: 1ex;"><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #fcaf3e; padding-left: 1ex;">running make install as root in the top-directory (however this <br></blockquote></blockquote>might leave your <br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #8ae234; padding-left: 1ex;"><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #fcaf3e; padding-left: 1ex;"> system in a rather odd state (until a package upgrade overrides it)<br> I personally always use the deb route for the GUI.<br><br> <br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #e9b96e; padding-left: 1ex;">Thanks und Greetings,<br>Julian <br></blockquote> Thank you!<br> stoiko<br><br> <br></blockquote><br></blockquote></blockquote></blockquote><br><br><br></pre></blockquote></div></body></html>