[pve-devel] [PATCH-SERIES v3] fix #3903: remove vmid from jobs.cfg on destroy

Thomas Lamprecht t.lamprecht at proxmox.com
Wed Mar 16 08:15:57 CET 2022


higher level comment: We cannot do it this way as it adds a cyclic dependency
between pve-container <-> pve-manager and qemu-server <-> pve-manager, which
is not allowed (such things, besides being ugly, make bootstrapping *a lot*
harder, and as I'm most often doing the bootstrap effort I NAK this).
pve-manager must only be a perl-module consumer for other repos, never a
provider.

I mean, it's not like Dominik and I did not predict such things when adding
the Jobs stuff in manager, but neither guest-common (there are guets unrelated
jobs we want to add like (finally) LDAP sync) nor pve-common (to high up the chain
means less access to other modules, e.g., pve-cluster) weren't a really good fitting
place then, especially as we had quite the time pressure, so we added all in
pve-manager as there we have the least coupling for moving it in the future.

I'd actually move the base jobs stuff to pve-cluster (possibly a new binary
package) as that's the highest point we can move it and it's not completely
wrong.





More information about the pve-devel mailing list