[pve-devel] applied: [PATCH qemu-server] fix #4372: fix vm_resume migration callback

Thomas Lamprecht t.lamprecht at proxmox.com
Wed Nov 30 16:22:49 CET 2022


Am 29/11/2022 um 13:09 schrieb Fabian Grünbichler:
> the fix for the recently introduced requirement of loading the VM config while
> migrating was incomplete, since the vmlist node value could already be out of
> date by the time load_config is called.
> 
> extend the fallback behaviour even further, by doing the following sequence:
> - try regular load_config (likely case, rename already fully processed)
> - if it fails, get node from vmlist, and load_config using that
> - it that fails, invalidate the PVE::Cluster cache, retry regular load_config
> 
> Signed-off-by: Fabian Grünbichler <f.gruenbichler at proxmox.com>
> ---
> 
> Notes:
>     an alternative approach would be to do the fallback load first, and if that
>     fails do the target node load. it has the downside of doing two loads in the
>     "good"/likely case where the rename is processed before the resume call, while
>     making the unlikely case (fallback needed) cheaper.
> 
>  PVE/QemuServer.pm | 16 +++++++++++-----
>  1 file changed, 11 insertions(+), 5 deletions(-)
> 
>

applied, thanks!





More information about the pve-devel mailing list