[pve-devel] [PATCH v3 proxmox 08/66] notify: api: add API for gotify endpoints

Lukas Wagner l.wagner at proxmox.com
Tue Jul 18 15:19:53 CEST 2023



On 7/18/23 14:44, Wolfgang Bumiller wrote:
>> +    }
>> +
>> +    if super::endpoint_exists(config, &endpoint_config.name) {
> 
> (*could* dedup the whole if into a helper in `super` so we don't need to
> copy-pasta the message to every new endpoint - we already have this
> twice now ;-) )
> 

Yup, a later commit actually moves that to a common helper `super::ensure_unique`.

-- 
- Lukas





More information about the pve-devel mailing list