[pve-devel] [PATCH installer] gui: make abort button unsensitive on last panel

Maximiliano Sandoval m.sandoval at proxmox.com
Wed Jun 21 11:57:42 CEST 2023


It makes no sense from a UX point of view to abort an install that's
already finished.

Signed-off-by: Maximiliano Sandoval <m.sandoval at proxmox.com>
---
 proxinstall | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/proxinstall b/proxinstall
index 6d13892..bf88b31 100755
--- a/proxinstall
+++ b/proxinstall
@@ -213,6 +213,7 @@ sub create_main_window {
     $gtk_state->{next_btn} = $next_btn;
     $gtk_state->{progress_bar} = Gtk3::ProgressBar->new();
     $gtk_state->{progress_status} = Gtk3::Label->new('');
+    $gtk_state->{abort_btn} = $abort;
 
     Proxmox::UI::init_gtk($gtk_state, $iso_env);
 
@@ -1522,6 +1523,10 @@ sub create_extract_view {
 	return $raw_html;
     };
 
+    # It does not make sense to Abort the install at this point, whether it
+    # succeded or failed makes no difference.
+    $gtk_state->{abort_btn}->set_sensitive(0);
+
     if ($err) {
 	Proxmox::UI::display_html("fail.htm");
 	# suppress "empty" error as we got some case where the user choose to abort on a prompt,
-- 
2.39.2






More information about the pve-devel mailing list