[pve-devel] [PATCH qemu-server 0/2] migration: fix sporadic nbd-server-stop timeout

[Fiona Ebner]

Am 29.09.23 um 10:28 schrieb Alexandre Derumier:
> I'm not sure, maybe it's related to writeback, because it never happend with a fresh started vm, but vms running since some time can trigger this.
> (I'm not sure, maybe nbd need to flush pending datas in cache ?)
> 

It does drain the export's BlockBackend, i.e. wait for all pending IO
before detaching/closing the export. But we did cancel the mirror job,
which should actually wait for any in-flight IO already, so it's a bit
surprising. Maybe there's some cache interaction happening at an
inconvenient time, no idea ¯\_(ツ)_/¯

The other thing it does is closing the connection to the client, so
there is at least that IO interaction and a higher timeout makes sense.

> 
> Alexandre Derumier (2):
>   nbd_stop: increase timeout to 25s
>   migration: add missing eval on nbdstop with tunnel v2.
> 

Patches look good to me, so consider them

Reviewed-by: Fiona Ebner <f.ebner at proxmox.com>

but they are missing your Signed-off-by trailer. Can you please add that?