[pve-devel] [PATCH manager 1/2] ui: dc: backup: improve UX for the different 'notification-mode's

[Thomas Lamprecht]

Am 14/12/2023 um 11:26 schrieb Maximiliano Sandoval:
> 
> Lukas Wagner <l.wagner at proxmox.com> writes:
> 
>>   - Switch order of 'mailto' and 'mailnotification' field
>>   - When mode is 'auto', disable 'mailtnotification' field
>>   - When mode is 'auto' and 'mailto' is empty, show
>>     hint that the notification system will be used
>>
>> Signed-off-by: Lukas Wagner <l.wagner at proxmox.com>
> 
> Tested both commits, they do what they promise.
> 
>> +	let notificationSystemHint = Ext.create({
>> +	    xtype: 'displayfield',
>> +	    padding: '0 0 0 5',
>> +	    userCls: 'pmx-hint',
>> +	    hidden: true,
>> +	    value: gettext('No email configured, the notification system will be used'),
>> +	    viewModel,
>> +	    bind: {
>> +		hidden: '{!hintTextVisible}',
> 
> I think the `pmx-hint` being displayed as yellow suggests it is a
> warning/error rather than a hint. I wonder if there is a better
> approach, as this is certainly not a warning.

Yeah, the hint is even often used as warning, having something more like a
"notice" or well, actual "hint" level, that isn't as flashy, might be a
good idea in the long run..

For now, we could also set a 'Hint' label and then add the pmx-hint class only
to the labelClsExtra config?

But I'm fine with this as is if you, Lukas, think that it's warranted (and
maybe even not showed that often in practice anyway).