[pve-devel] [PATCH v2 manager] pvesubscription: add missing return statement

Alexander Zeidler a.zeidler at proxmox.com
Mon Jan 29 10:47:05 CET 2024


to avoid a failing null check and its error message. This confused
users since the activation was successful anyway.

Signed-off-by: Alexander Zeidler <a.zeidler at proxmox.com>
---
v2:
* use "return" instead of "return undef"
* add commit message

v1: https://lists.proxmox.com/pipermail/pve-devel/2024-January/061280.html

 PVE/CLI/pvesubscription.pm | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/PVE/CLI/pvesubscription.pm b/PVE/CLI/pvesubscription.pm
index efd4ada4..51f5b71e 100755
--- a/PVE/CLI/pvesubscription.pm
+++ b/PVE/CLI/pvesubscription.pm
@@ -48,6 +48,8 @@ __PACKAGE__->register_method({
 	PVE::API2::Subscription::check_key($info->{key}, PVE::API2::Subscription::get_sockets());
 
 	PVE::API2::Subscription::write_etc_subscription($info);
+
+	return;
 }});
 
 our $cmddef = {
-- 
2.39.2





More information about the pve-devel mailing list