[pve-devel] applied: [PATCH manager] ui: guest import: allow setting mac addresses to unique

[Aaron Lauterer]

On  2024-03-27  11:26, Thomas Lamprecht wrote:
> Am 26/03/2024 um 14:25 schrieb Aaron Lauterer:
>> by adding a new checkbox and render the grid accordingly.
>>
>> If unique MAC addresses are enabled, set them to undefined when getting
>> the values from the grid.
>>
>> Signed-off-by: Aaron Lauterer <a.lauterer at proxmox.com>
>> ---
>> not sure if setting `uniqueMac` directly on the component is okay.
>> Though we do that dynamically for the `vmConfig` as well. So probably
>> okayish.
>>
>>   www/manager6/window/GuestImport.js | 39 +++++++++++++++++++++++++++++-
>>   1 file changed, 38 insertions(+), 1 deletion(-)
>>
>>
> 
> applied, with a follow-up to rework this using the viewModel for tracking
> the state instead of doing that in a config option of the widget, thanks!

thanks!

I did choose the 'labelWidth' and 'fieldLabel' to match the look and 
feel of the 'Prepare for Virtio-SCSI" checkbox further up for 
consistency though.

Maybe we want to change that back?