[pve-devel] [PATCH 3/6] add vm_deviceadd sub

[Dietmar Maurer]

> +sub vm_deviceadd {
> +    my ($storecfg,$vmid, $deviceid,$device) = @_;
> +
> +    my $cfspath = cfs_config_path($vmid);
> +    my $conf = PVE::Cluster::cfs_read_file($cfspath) || {};


Please can we avoid that ::cfs_read_file() - we can simply pass the conf to the function:

sub vm_deviceadd {
    my ($conf, $storecfg, $vmid, $deviceid, $device) = @_;
..

sub vm_devicedel {
    my ($conf, $vmid, $deviceid) = @_;
...