[pve-devel] [PATCH] Hack for allowing browser to autofill the login form

Dietmar Maurer dietmar at proxmox.com
Fri Apr 6 08:13:51 CEST 2012


I still think the functionality is wrong. We want auto completion for several users - else it does not make much sense for me.

Also, you simply use field 'username', and ignore the realm! For example the root user
is 'rootpam' (not 'root').

Programming Tips: Do not use "document.getElementById", use Ext.getDom() instead.

- Dietmar

> -----Original Message-----
> From: Neliger [mailto:contact at neliger.com]
> Sent: Donnerstag, 05. April 2012 14:24
> To: Dietmar Maurer; pve-devel at pve.proxmox.com
> Subject: Re: [pve-devel] [PATCH] Hack for allowing browser to autofill the login
> form
> 
> 
> Le 5 avr. 2012 à 14:02, Neliger a écrit :
> 
> >
> > Le 5 avr. 2012 à 13:37, Dietmar Maurer a écrit :
> >
> >>> Mistake : the iframe IS necessary !
> >>
> >> Why?
> >
> >
> > We need to submit a real HTML form to get the browser asking for saving
> login/pass.
> >
> > So I target this hidden form to an IFRAME, as this won't disturb the whole
> script execution.
> 
> 
> Here's the new patch with corrected auto-complete problem with your help,
> Dietmar.
> 
> PS: could you add the "Reply-to: pve-devel at pve.proxmox.com" header like on
> other mailing-list ? It would be great.





More information about the pve-devel mailing list