[pve-devel] problem with my nexenta plugin when start vm with pve-manager, need perl help

[Dietmar Maurer]

Why you read something form external files, you need to parse the data.
That’s all - else perl taint mode throws errors.

There is no need to parse anything inside run_command.

- Dietmar

> -----Original Message-----
> From: pve-devel-bounces at pve.proxmox.com [mailto:pve-devel-
> bounces at pve.proxmox.com] On Behalf Of Alexandre DERUMIER
> Sent: Dienstag, 21. August 2012 15:01
> To: Stefan Priebe - Profihost AG
> Cc: pve-devel at pve.proxmox.com
> Subject: Re: [pve-devel] problem with my nexenta plugin when start vm with
> pve-manager, need perl help
> 
> >>No problem but are there any other cases where we pass parameters to a
> >>system call? We need to regex check them all...
> What was the problem exactly ?
> 
> 
> I don't see param verification in
> /usr/share/perl5/PVE/Tools.pm
> sub run_command {
>     my ($cmd, %param) = @_;
>    ....
>  $pid = open3($writer, $reader, $error, @$cmd) || die $!;
> 
> 
> ----- Mail original -----
> 
> De: "Stefan Priebe - Profihost AG" <s.priebe at profihost.ag>
> À: "Alexandre DERUMIER" <aderumier at odiso.com>
> Cc: pve-devel at pve.proxmox.com
> Envoyé: Mardi 21 Août 2012 14:53:39
> Objet: Re: problem with my nexenta plugin when start vm with pve-manager,
> need perl help
> 
> Am 21.08.2012 14:39, schrieb Alexandre DERUMIER:
> > Oh, It's working !
> >
> > Thanks !
> >
> > I'll send a patch.
> 
> No problem but are there any other cases where we pass parameters to a
> system call? We need to regex check them all...
> 
> Stefan
> 
> 
> 
> --
> 
> --
> 
> 
> 
> 
> 
> Alexandre D e rumier
> 
> Ingénieur Systèmes et Réseaux
> 
> 
> Fixe : 03 20 68 88 85
> 
> Fax : 03 20 68 90 88
> 
> 
> 45 Bvd du Général Leclerc 59100 Roubaix
> 12 rue Marivaux 75002 Paris
> _______________________________________________
> pve-devel mailing list
> pve-devel at pve.proxmox.com
> http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel