[pve-devel] [PATCH] nexenta: fix lun number parsing in sub path

Dietmar Maurer dietmar at proxmox.com
Wed Aug 22 12:27:29 CEST 2012


applied, thanks.

But almost any patch from you contains white space errors:

Applying: nexenta: fix lun number parsing in sub path
/home/dietmar/pve2-devel/pve-storage/.git/rebase-apply/patch:15: trailing whitespace.
    $lun = $1;    
warning: 1 line adds whitespace errors.

How can we avoid that in future?

> -----Original Message-----
> From: pve-devel-bounces at pve.proxmox.com [mailto:pve-devel-
> bounces at pve.proxmox.com] On Behalf Of Alexandre Derumier
> Sent: Dienstag, 21. August 2012 14:44
> To: pve-devel at pve.proxmox.com
> Subject: [pve-devel] [PATCH] nexenta: fix lun number parsing in sub path
> 
> 
> Signed-off-by: Alexandre Derumier <aderumier at odiso.com>
> ---
>  PVE/Storage/NexentaPlugin.pm |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/PVE/Storage/NexentaPlugin.pm b/PVE/Storage/NexentaPlugin.pm
> index 9352c74..b1a3516 100644
> --- a/PVE/Storage/NexentaPlugin.pm
> +++ b/PVE/Storage/NexentaPlugin.pm
> @@ -198,7 +198,8 @@ sub path {
>      my $map = nexenta_list_lun_mapping_entries($name,$scfg);
>      die "could not find lun number" if !$map;
>      my $lun = @$map[0]->{lun};
> -
> +    $lun =~ m/^(\d+)$/ or die "lun is not OK\n";
> +    $lun = $1;
>      my $path = "iscsi://$portal/$target/$lun";
> 
>      return ($path, $vmid, $vtype);
> --
> 1.7.2.5
> 
> _______________________________________________
> pve-devel mailing list
> pve-devel at pve.proxmox.com
> http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel




More information about the pve-devel mailing list