[pve-devel] [PATCH 2/3] use scsi-generic by default with libiscsi

Dietmar Maurer dietmar at proxmox.com
Wed Aug 29 07:54:57 CEST 2012


I am still confused. Why don't we always use the 'generic' driver if it is faster?

> -	      $devicetype = 'block' if path_is_scsi($path);
> +	      $devicetype = 'generic' if path_is_scsi($path);


> -----Original Message-----
> From: pve-devel-bounces at pve.proxmox.com [mailto:pve-devel-
> bounces at pve.proxmox.com] On Behalf Of Alexandre Derumier
> Sent: Dienstag, 28. August 2012 12:46
> To: pve-devel at pve.proxmox.com
> Subject: [pve-devel] [PATCH 2/3] use scsi-generic by default with libiscsi
> 
> This add scsi passthrough with libiscsi
> 
> Signed-off-by: Alexandre Derumier <aderumier at odiso.com>
> ---
>  PVE/QemuServer.pm |    8 +++++++-
>  1 files changed, 7 insertions(+), 1 deletions(-)
> 
> diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index
> 74b8b65..8731d99 100644
> --- a/PVE/QemuServer.pm
> +++ b/PVE/QemuServer.pm
> @@ -988,7 +988,13 @@ sub print_drivedevice_full {
>                } else {
>                    $path = PVE::Storage::path($storecfg, $drive->{file});
>                }
> -	      $devicetype = 'block' if path_is_scsi($path);
> +
> +	      if($path =~ m/^iscsi\:\/\//){
> +		 $devicetype = 'generic';
> +	      }
> +	      else {
> +		 $devicetype = 'block' if path_is_scsi($path);
> +	      }
>           }
> 
>          if (!$conf->{scsihw} || $conf->{scsihw} eq 'lsi'){
> --
> 1.7.2.5
> 
> _______________________________________________
> pve-devel mailing list
> pve-devel at pve.proxmox.com
> http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel




More information about the pve-devel mailing list