[pve-devel] [PATCH 2/3] use scsi-generic by default with libiscsi

Alexandre DERUMIER aderumier at odiso.com
Wed Aug 29 08:12:20 CEST 2012


because passthrough is enable with scsi-generic + libiscsi 
http://lists.gnu.org/archive/html/qemu-devel/2012-04/msg04139.html 


Can't tell for scsi-block, but stefan have had a discussion about it with qemu devels.


----- Mail original ----- 

De: "Dietmar Maurer" <dietmar at proxmox.com> 
À: "Alexandre Derumier" <aderumier at odiso.com>, pve-devel at pve.proxmox.com 
Envoyé: Mercredi 29 Août 2012 07:54:57 
Objet: RE: [pve-devel] [PATCH 2/3] use scsi-generic by default with libiscsi 

I am still confused. Why don't we always use the 'generic' driver if it is faster? 

> - $devicetype = 'block' if path_is_scsi($path); 
> + $devicetype = 'generic' if path_is_scsi($path); 


> -----Original Message----- 
> From: pve-devel-bounces at pve.proxmox.com [mailto:pve-devel- 
> bounces at pve.proxmox.com] On Behalf Of Alexandre Derumier 
> Sent: Dienstag, 28. August 2012 12:46 
> To: pve-devel at pve.proxmox.com 
> Subject: [pve-devel] [PATCH 2/3] use scsi-generic by default with libiscsi 
> 
> This add scsi passthrough with libiscsi 
> 
> Signed-off-by: Alexandre Derumier <aderumier at odiso.com> 
> --- 
> PVE/QemuServer.pm | 8 +++++++- 
> 1 files changed, 7 insertions(+), 1 deletions(-) 
> 
> diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index 
> 74b8b65..8731d99 100644 
> --- a/PVE/QemuServer.pm 
> +++ b/PVE/QemuServer.pm 
> @@ -988,7 +988,13 @@ sub print_drivedevice_full { 
> } else { 
> $path = PVE::Storage::path($storecfg, $drive->{file}); 
> } 
> - $devicetype = 'block' if path_is_scsi($path); 
> + 
> + if($path =~ m/^iscsi\:\/\//){ 
> + $devicetype = 'generic'; 
> + } 
> + else { 
> + $devicetype = 'block' if path_is_scsi($path); 
> + } 
> } 
> 
> if (!$conf->{scsihw} || $conf->{scsihw} eq 'lsi'){ 
> -- 
> 1.7.2.5 
> 
> _______________________________________________ 
> pve-devel mailing list 
> pve-devel at pve.proxmox.com 
> http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel 





-- 

-- 



	

Alexandre D e rumier 

Ingénieur Systèmes et Réseaux 


Fixe : 03 20 68 88 85 

Fax : 03 20 68 90 88 


45 Bvd du Général Leclerc 59100 Roubaix 
12 rue Marivaux 75002 Paris 



More information about the pve-devel mailing list