[pve-devel] [PATCH 8/8] add_unused_volume corrections.

Dietmar Maurer dietmar at proxmox.com
Mon Jan 23 09:34:51 CET 2012


Hi Alexandre,

just applied patch 1/8-7/8, but I do not understand this one: 

> -----Original Message-----
> From: pve-devel-bounces at pve.proxmox.com [mailto:pve-devel-
> bounces at pve.proxmox.com] On Behalf Of Derumier Alexandre
> Sent: Freitag, 20. Jänner 2012 11:42
> To: pve-devel at pve.proxmox.com
> Subject: [pve-devel] [PATCH 8/8] add_unused_volume corrections.
> 
> Currentle add_unused_volume not working when delete more than 1 device.
> 
> As it reading the vm conf file each time, it always assign the same id to each
> delete device.

We only load the config file once in PVE/API2/Qemu.pm line 495?

Please can you post a example to reproduce the bug?

Besides, I think we should simplify the update_vm code.

The current API tries to guarantee atomic updates if you change multiple
values. I guess That is simply not possible because you can't guarantee
that revert/undo works (especially when we use hotplug).

I suggest that we split updates into single changes, and save the config
file after each changes. On error, we simple stop. I guess we can simplify
the code that way.

What do you think (AFAIR you already suggested that)?

- Dietmar







More information about the pve-devel mailing list