[pve-devel] [PATCH 02/21] plugin : add volume_snapshot

[Alexandre DERUMIER]

Oh, indeed, no internal snapshot for qed, only external.

We can remove it.



----- Mail original ----- 

De: "Dietmar Maurer" <dietmar at proxmox.com> 
À: "Alexandre Derumier" <aderumier at odiso.com>, pve-devel at pve.proxmox.com 
Envoyé: Jeudi 6 Septembre 2012 10:40:35 
Objet: RE: [pve-devel] [PATCH 02/21] plugin : add volume_snapshot 

Does format 'qed' supports snapshots now? 

> +sub volume_snapshot { 
> + my ($class, $scfg, $storeid, $volname, $snap, $running) = @_; 
> + 
> + die "can't snapshot this image format" if $volname !~ 
> + m/\.(qcow2|qed)$/; 
> + 
> + return 1 if $running; 
> + 
> + my $path = $class->path($scfg, $volname); 
> + 
> + my $cmd = ['/usr/bin/qemu-img', 'snapshot','-c', $snap, $path]; 
> + 
> + run_command($cmd, timeout => 1); 
> + 
> + return undef; 
> +} 
> +