[pve-devel] snapshot improvements

[Alexandre DERUMIER]

>>Unfortunately, the qemu code seem to report wrong values for 'remaining' 
>>bytes. So I had to increase allocated space to: 
>>
>>my $size = $conf->{memory}*2 + $driver_state_size; 
>>
>>Note: we truncate the file after save if possible. 

Ok, I'll rested that today


yesterday tests show no filesystem corruption, running a fio write benchmark and take snapshot with vmstate,

rollbacking, with fio benchmerk continue to write again, rollback,rollback.

So it's seem stable.





----- Mail original ----- 

De: "Dietmar Maurer" <dietmar at proxmox.com> 
À: "Dietmar Maurer" <dietmar at proxmox.com>, "Alexandre DERUMIER" <aderumier at odiso.com> 
Cc: pve-devel at pve.proxmox.com 
Envoyé: Mardi 25 Septembre 2012 10:37:42 
Objet: RE: [pve-devel] snapshot improvements 

> > do you think image = size of memory if enough ? (if we have some bytes 
> > more with incremental ?) 
> 
> PVE/QemuServer.pm: 
> 
> my $driver_state_size = 32; # assume 32MB is enough to safe all driver 
> state; 
> my $size = $conf->{memory} + $driver_state_size; 

Unfortunately, the qemu code seem to report wrong values for 'remaining' 
bytes. So I had to increase allocated space to: 

my $size = $conf->{memory}*2 + $driver_state_size; 

Note: we truncate the file after save if possible. 

- Dietmar