[pve-devel] [PATCH] template create : add template:1 option

[Alexandre DERUMIER]

It's ok now !

(tested with vm without disk, iscsi disks without rename, and disks with rename to base-xxx)


----- Mail original ----- 

De: "Alexandre DERUMIER" <aderumier at odiso.com> 
À: "Dietmar Maurer" <dietmar at proxmox.com> 
Cc: pve-devel at pve.proxmox.com 
Envoyé: Lundi 22 Avril 2013 10:53:21 
Objet: Re: [pve-devel] [PATCH] template create : add template:1 option 

Another error: 

Use of inherited AUTOLOAD for non-method PVE::API2::Qemu::check_running() is deprecated at /usr/share/perl5/PVE/API2/Qemu.pm line 2401. 
Can't call method "map_method_by_name" without a package or object reference at /usr/share/perl5/PVE/RESTHandler.pm line 197. 



in Qemu.pm 

die "you can't convert a VM to template if VM is running\n" 
if check_running($vmid); 


should be 

PVE::QemuServer::check_running($vmid); 



----- Mail original ----- 

De: "Dietmar Maurer" <dietmar at proxmox.com> 
À: "Alexandre DERUMIER" <aderumier at odiso.com> 
Cc: pve-devel at pve.proxmox.com 
Envoyé: Lundi 22 Avril 2013 09:43:09 
Objet: RE: [pve-devel] [PATCH] template create : add template:1 option 

sorry, just pushed the update - will arrive in a few minutes. 

> -----Original Message----- 
> From: Alexandre DERUMIER [mailto:aderumier at odiso.com] 
> Sent: Montag, 22. April 2013 09:37 
> To: Dietmar Maurer 
> Cc: pve-devel at pve.proxmox.com 
> Subject: Re: [pve-devel] [PATCH] template create : add template:1 option 
> 
> 
> I don't see the commit in proxmox git ? 
> 
> 
> 
> ----- Mail original ----- 
> 
> De: "Dietmar Maurer" <dietmar at proxmox.com> 
> À: "Alexandre DERUMIER" <aderumier at odiso.com> 
> Cc: pve-devel at pve.proxmox.com 
> Envoyé: Lundi 22 Avril 2013 09:09:44 
> Objet: RE: [pve-devel] [PATCH] template create : add template:1 option 
> 
> So we need to adopt that check. I just applied a fix 
> 
> die "unable to create template, because VM contains snapshots\n" 
> if $conf->{snapshots} && scalar(keys %{$conf->{snapshots}}); 
> 
> 
> 
> 
> > -----Original Message----- 
> > From: Alexandre DERUMIER [mailto:aderumier at odiso.com] 
> > Sent: Montag, 22. April 2013 09:03 
> > To: Dietmar Maurer 
> > Cc: pve-devel at pve.proxmox.com 
> > Subject: Re: [pve-devel] [PATCH] template create : add template:1 option 
_______________________________________________ 
pve-devel mailing list 
pve-devel at pve.proxmox.com 
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel