[pve-devel] [PATCH 1/5] add qemu_img_convert

[Alexandre DERUMIER]

some first notes :

I think it could be great to add a "name" parameter

For full clone, we should add a target storage and output format options.
(I think that only 1 target storage/output format for all disks is enough)




Also , currently when I do a full clone of a vm with qcow2 disk, I have a .raw target disk.

my $fmt = $drive->{format} || $defformat;

seem that $drive->{format} is always empty, but it seem to be a bug in parse_drive,
as we don't have a format=... option on drive. (instead,we need to parse the extension of the file in parse_drive)






----- Mail original ----- 

De: "Alexandre DERUMIER" <aderumier at odiso.com> 
À: "Dietmar Maurer" <dietmar at proxmox.com> 
Cc: pve-devel at pve.proxmox.com 
Envoyé: Lundi 29 Avril 2013 12:59:03 
Objet: Re: [pve-devel] [PATCH 1/5] add qemu_img_convert 

>>I think create_vm is already too complex to add more functionality. 
>>What do you think? 

Yes, I also was unhappy with extending qm create 

>>My plan was to get this basic functionality stable so 
>>that we can include this with 3.0? 

Yes, I think it could be a start, we can add features step by step. 
When do you plan to release 3.0 ? 


I'll test your code today 




----- Mail original ----- 

De: "Dietmar Maurer" <dietmar at proxmox.com> 
À: "Alexandre Derumier" <aderumier at odiso.com>, pve-devel at pve.proxmox.com 
Envoyé: Lundi 29 Avril 2013 11:03:50 
Objet: RE: [pve-devel] [PATCH 1/5] add qemu_img_convert 

I finally applied this one and a first version of copy_vm. 

I moved the code into an extra API call, because copy/clone has 
different locking requirements than create_vm. We now create 
a shared lock on the source VM. Also, permission checks are slightly 
different, and I think create_vm is already too complex to add more functionality. 

What do you think? My plan was to get this basic functionality stable so 
that we can include this with 3.0? 


> -----Original Message----- 
> From: pve-devel-bounces at pve.proxmox.com [mailto:pve-devel- 
> bounces at pve.proxmox.com] On Behalf Of Alexandre Derumier 
> Sent: Montag, 29. April 2013 08:41 
> To: pve-devel at pve.proxmox.com 
> Subject: [pve-devel] [PATCH 1/5] add qemu_img_convert 
> 
> also work with snapshot as source for qcow2,rbd,sheepdog. 
> 
_______________________________________________ 
pve-devel mailing list 
pve-devel at pve.proxmox.com 
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel