[pve-devel] grave bug in move disk discovered

Dietmar Maurer dietmar at proxmox.com
Mon Apr 14 06:30:06 CEST 2014


> > after move disk, if you remove the original disk in gui, and that a
> > snasphot exist with this disk, the disk is removed from the current
> > config, but the datas are not removed.
> 
> AFAIK we keep a reference as 'unusedX' disk. This reference should not be
> removed as long as there are snapshots?

Looking at the code reveals:

		if ($param->{delete}) {
		    eval { PVE::Storage::vdisk_free($storecfg, $old_volid); };
		    warn $@ if $@;
		}

We must not unconditionally delete a volume if the volume is used by snapshots!
Anybody wants to write a patch for that?



More information about the pve-devel mailing list