[pve-devel] [PATCH 2/2] bridge rules : -j ACCEPT for physical interfaces

[Dietmar Maurer]

Maybe you can add a short explanation to the commit log?

> -----Original Message-----
> From: pve-devel-bounces at pve.proxmox.com [mailto:pve-devel-
> bounces at pve.proxmox.com] On Behalf Of Dietmar Maurer
> Sent: Dienstag, 25. Februar 2014 13:33
> To: Alexandre Derumier; pve-devel at pve.proxmox.com
> Subject: Re: [pve-devel] [PATCH 2/2] bridge rules : -j ACCEPT for physical
> interfaces
> 
> Why do we accept unrelated traffic?
> 
> > -----Original Message-----
> > From: pve-devel-bounces at pve.proxmox.com [mailto:pve-devel-
> > bounces at pve.proxmox.com] On Behalf Of Alexandre Derumier
> > Sent: Dienstag, 25. Februar 2014 13:24
> > To: pve-devel at pve.proxmox.com
> > Subject: [pve-devel] [PATCH 2/2] bridge rules : -j ACCEPT for physical
> > interfaces
> >
> >
> > Signed-off-by: Alexandre Derumier <aderumier at odiso.com>
> > ---
> >  PVE/Firewall.pm |    1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/PVE/Firewall.pm b/PVE/Firewall.pm index ea24cfb..343f60c
> > 100644
> > --- a/PVE/Firewall.pm
> > +++ b/PVE/Firewall.pm
> > @@ -653,6 +653,7 @@ sub generate_bridge_chains {
> >      if (!ruleset_chain_exist($ruleset, "$bridge-IN")) {
> >  	ruleset_create_chain($ruleset, "$bridge-IN");
> >  	ruleset_addrule($ruleset, "$bridge-FW", "-m physdev --physdev-is-
> > bridged --physdev-is-out -j $bridge-IN");
> > +	ruleset_addrule($ruleset, "$bridge-FW", "-j ACCEPT");
> >      }
> >  }
> >
> > --
> > 1.7.10.4
> >
> > _______________________________________________
> > pve-devel mailing list
> > pve-devel at pve.proxmox.com
> > http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
> 
> 
> _______________________________________________
> pve-devel mailing list
> pve-devel at pve.proxmox.com
> http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel