[pve-devel] [PATCH] check for valid config changes

Dietmar Maurer dietmar at proxmox.com
Wed Feb 26 06:28:15 CET 2014


> Am 25.02.2014 16:48, schrieb Dietmar Maurer:
> >> -	    foreach my $opt (keys %$param) { # add/change
> >> +	    my $conf_param = { %$param, map {$_ => undef} @delete };
> >
> > I guess you need to process @delete parameters first? Or maybe we
> > should check that we do net set both (param value and delete)?
> 
> my idea was that delete is more important than param so @delete params
> overwrite param.
> 
> Can it happen that we have both?

AFAIK nothing prevents that (should be easy to test).

Besides, the update code is on the list of things I want ti simplify. IMHO
the code is already too complex.

Any idea how we can make that code simpler?




More information about the pve-devel mailing list