[pve-devel] [PATCH] add -full option to pve-firewall compile

[Dietmar Maurer]

Sorry, I don't really understand this patch. You suppress error
here, instead of making output more verbose?

>  sub iptables_restore_cmdlist {
> -    my ($cmdlist) = @_;
> +    my ($cmdlist, $verbose) = @_;
> 
> -    run_command("/sbin/iptables-restore -n", input => $cmdlist);

Note: Above command always print stderr output.

> +    my $errfunc = sub {
> +	return if !$verbose;

Now you suppress errors until you run with $verbose. I want to see errors always.

> +	my $line = shift;
> +	print $line."\n";
> +    };
> +
> +    run_command("/sbin/iptables-restore -n", errfunc => $errfunc, input
> + => $cmdlist);