[pve-devel] [PATCH] linux bridge and ovs new model implementation v6

[Alexandre DERUMIER]

or maybe,

on enable|disable firewall from network interface configuration,
and not in vmid.fw

(so no need PVE::Firewall anywhere)

----- Mail original ----- 

De: "Alexandre DERUMIER" <aderumier at odiso.com> 
À: "Dietmar Maurer" <dietmar at proxmox.com> 
Cc: pve-devel at pve.proxmox.com 
Envoyé: Mardi 6 Mai 2014 08:29:07 
Objet: Re: [pve-devel] [PATCH] linux bridge and ovs new model implementation v6 

>>Sorry, but we can't simply introduce such dependency! The script need to work without that. 

Yes, I thinked about that. 

maybe implement a small vm firewall config parser in Network.pm (we just need to check firewall:1|0) 
is enough ? 

or do you have a better idea ? 



----- Mail original ----- 

De: "Dietmar Maurer" <dietmar at proxmox.com> 
À: "Alexandre Derumier" <aderumier at odiso.com>, pve-devel at pve.proxmox.com 
Envoyé: Mardi 6 Mai 2014 08:25:23 
Objet: RE: [pve-devel] [PATCH] linux bridge and ovs new model implementation v6 

> data/PVE/Network.pm | 242 
> +++++++++++++++++++++++++++++++++++++++++++++++---- 
> 1 file changed, 223 insertions(+), 19 deletions(-) 
> 
> diff --git a/data/PVE/Network.pm b/data/PVE/Network.pm index 
> 4677bf9..fb89cbf 100644 
> --- a/data/PVE/Network.pm 
> +++ b/data/PVE/Network.pm 
> @@ -2,10 +2,12 @@ package PVE::Network; 
> 
> use strict; 
> use warnings; 
> -use PVE::Tools qw(run_command); 
> +use PVE::Tools qw(run_command file_get_contents); 
> use PVE::ProcFSTools; 
> use PVE::INotify; 
> +use PVE::Firewall; 

Sorry, but we can't simply introduce such dependency! The script need to work without that. 
_______________________________________________ 
pve-devel mailing list 
pve-devel at pve.proxmox.com 
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel