[pve-devel] [PATCH 5/7] vmconfig_hotplug_pending : add cpu hotplug

[Alexandre DERUMIER]

Qemu only support core hotplug, so socket must = 1 to be able to hotplug core.


----- Mail original ----- 

De: "Dietmar Maurer" <dietmar at proxmox.com> 
À: "Alexandre Derumier" <aderumier at odiso.com>, pve-devel at pve.proxmox.com 
Envoyé: Mercredi 19 Novembre 2014 10:09:16 
Objet: RE: [pve-devel] [PATCH 5/7] vmconfig_hotplug_pending : add cpu hotplug 

We have 'sockets' and 'cores' inside out VM config. Your CPU hotplug 
simply use $cores 

Note: we start the VM with $socket*$cores CPUs 

my $total_cores = $sockets * $cores; 

So I guess this is a bug? 

> sub qemu_block_set_io_throttle { 
> @@ -3519,7 +3520,13 @@ sub vmconfig_hotplug_pending { 
> delete $conf->{pending}->{$opt}; 
> } 
> } 
> - } 
> + } elsif($opt eq 'cores'){ 
> + if(PVE::QemuServer::qemu_cpu_hotplug($vmid, $conf, $conf- 
> >{pending}->{$opt})){ 
> + $conf->{$opt} = $conf->{pending}->{$opt}; 
> + delete $conf->{pending}->{$opt}; 
> + } 
> + } 
> +