[pve-devel] [PATCH 5/7] vmconfig_hotplug_pending : add cpu hotplug

[Alexandre DERUMIER]

>>But you do not check if $sockets == 1 (can't see it)? 
Oh, sorry, I think I forgot to readd it when I rebase my patches

we can add:


sub qemu_cpu_hotplug {
    my ($vmid, $conf, $cores) = @_;

    ...
    return if $conf->{sockets} && $conf->{sockets} > 1;


----- Mail original ----- 

De: "Dietmar Maurer" <dietmar at proxmox.com> 
À: "Alexandre DERUMIER" <aderumier at odiso.com> 
Cc: pve-devel at pve.proxmox.com 
Envoyé: Mercredi 19 Novembre 2014 10:32:42 
Objet: RE: [pve-devel] [PATCH 5/7] vmconfig_hotplug_pending : add cpu hotplug 

> Qemu only support core hotplug, so socket must = 1 to be able to hotplug core. 

But you do not check if $sockets == 1 (can't see it)?