[pve-devel] vm_deviceunplug question

[Alexandre DERUMIER]

>>Please can you also review the latest hotplug changes, especially the
>>error handling? I think we get better error messages this way.

Yes, I wanted to fix that since a long time, thanks.

About network hotplug,
I have exception if I try to change the bridge for example, and conf->{hotplug} = 0.

I think this is because be always call   

vm_deviceplug($storecfg, $conf, $vmid, $opt, $newnet);

at the end of vmconfig_update_net.



----- Mail original ----- 

De: "Dietmar Maurer" <dietmar at proxmox.com> 
À: "Alexandre DERUMIER" <aderumier at odiso.com> 
Cc: pve-devel at pve.proxmox.com 
Envoyé: Mardi 25 Novembre 2014 10:46:33 
Objet: RE: vm_deviceunplug question 

> for scsi: 
> 
> -device virtio-scsi-pci,id=scsihw0,bus=pci.0,addr=0x5 
> -drive file=/var/lib/vz/images/115/vm-115-disk-34.raw,if=none,id=drive-scsi0 
> -device scsi-hd,bus=scsihw0.0,channel=0,scsi-id=0,lun=0,drive=drive- 
> scsi0,id=scsi0 
> 
> 
> we remove scsi-hd device and drive. (this is not a pci device|controler,so we 
> don't need to check if removal is ok). 

Ah, OK - thank for the explanation. 

Please can you also review the latest hotplug changes, especially the 
error handling? I think we get better error messages this way.