[pve-devel] [PATCH 2/5] add mountpoint_activate sub

[Dietmar Maurer]

I do not like this whole series, because you define
subroutines with unexpected side effects. 

For example, an naive developer want to call:

mountpoint_activate('rootfs', ...)

which does nothing for some reason?

You should really do those checks somewhere else.

Also, we want to activate/deactivate all volumes at once, because 

PVE::Storage::activate_volumes($storage_cfg, [...]);

can take several $volids, and is optimized to activate each
storage only once.