[pve-devel] [PATCH pve-manager 2/2] Add new commands for zfs, network, lxc

[Dietmar Maurer]

> On 12/07/2015 12:29 PM, Dietmar Maurer wrote:
> > That looks a bit too much for me - is all that required?
> 
> Well you never know what you're going to need when diagnosing a problem.

You can still ask if you need more...

> These additions were suggested to me, I suppose there was
> a need for it coming from past diagnose reports.

any comment form the one who suggested this?

> 
> Actually we can get rid of 'ip addr show', as the same information is
> provided by ifconfig, and ifconfig provides additional RX/TX statistics.

And why do you need 'iptables-save' two times?

> 
> >> -my @net = ('ifconfig', 'cat /etc/network/interfaces', sub {
> >> dir2text('/etc/pve/firewall/', '.*fw') },
> >> -  'iptables-save');
> >> +my @net = ('ifconfig',
> >> +  'cat /etc/network/interfaces',
> >> +  sub { dir2text('/etc/pve/firewall/', '.*fw') },
> >> +  'iptables-save',
> >> +  'iptables-save',
> > 
> > 2 times?
> > 
> >> +  'ip addr show',
> >> +  'bridge -c vlan show',
> >> +  'ip route show',
> >> +  'ip -6 route show',
> >> +  'ip neigh show',
> >> +  'ip neigh show proxy',
> >> +  'sysctl net.bridge',
> >> +  'sysctl net.ipv4',
> >> +  'sysctl net.ipv6'
> >> +);