[pve-devel] [PATCH] qmp drive_add : remove backslashes from $drive string

Stefan Priebe - Profihost AG s.priebe at profihost.ag
Mon Mar 2 08:20:46 CET 2015


Am 01.03.2015 um 13:23 schrieb Dietmar Maurer:
>> Isn't the correct fix not to include \ in the output of print_drive_full?
>>
>> I think escaping should be done in the routines using print_drive_full.
> 
> But what are the quoting rules? Can we use String::ShellQuote()?

I think so. I think the most important stuff is that the
print_drive_full routine does not know what the caller wants. So it
can't quote in the right way. This MUST happen in the caller routine.

Stefan



More information about the pve-devel mailing list