[pve-devel] [PATCH] balloon: use qom-get for guest balloon statistics V5

[Alexandre DERUMIER]

>>No. I assumed V5 is already well tested ;-) 
Oops sorry, next time i'll mark it as rfc



I think I have a little bug,

qmp query-balloon return bytes,


+# @free_mem: #optional amount of memory (in bytes) free in the guest
+#
+# @total_mem: #optional amount of memory (in bytes) visible to the guest
+#
+# @max_mem: amount of memory (in bytes) assigned to the guest


but hmp, MBytes.


I need to fix that. 

I'll test with debugging pvestatd before send the final patch








----- Mail original -----
De: "dietmar" <dietmar at proxmox.com>
À: "aderumier" <aderumier at odiso.com>
Cc: "pve-devel" <pve-devel at pve.proxmox.com>
Envoyé: Vendredi 6 Mars 2015 11:06:29
Objet: Re: [pve-devel] [PATCH] balloon: use qom-get for guest balloon statistics V5

> Do you have tested it ? 

No. I assumed V5 is already well tested ;-) 

I already applied it to both branches, and uploaded packages to the pvetest 
repository. 

Please mark patches if you do not want that I commit them. 

> I'm unsure about "actual" = "stat-total-memory". 
> 
> It seem that guest alwats report a little less memory (around 100MB) than 
> balloon target. 

but this does not harm, and it does not explain the problem the user reported on 
the forum?