[pve-devel] [PATCH 5/5] DRBD: Implement snapshots.

[Philipp Marek]

Sorry, I used "git email-send" badly -- I wanted to write preface email,
as usual, but forgot the --compose commandline argument (and "compose=true" 
in .git/config doesn't seem to work).


About this patch I wanted to mention a few things:

 * This implementation works with the small script at
     http://pve.proxmox.com/pipermail/pve-devel/2015-September/017022.html 

 * There's no implementation for volume_snapshot_rollback() yet.
   Is there a way to change the volume name on rollback?
   The problem is that DRBDmanage (as of now) won't allow to _replace_
   the current contents with the ones from the snapshot --
   but perhaps we want to implement that at some time.

 * For volume_has_feature(), what's the difference between "current" and 
   "snap" etc.?
      +        snapshot => { current => 1, snap => 1},


Thank you for any feedback!