[pve-devel] [PATCH manager 09/10] drop all hide calls

Dominik Csapak d.csapak at proxmox.com
Mon Aug 22 17:13:41 CEST 2016


since we do not use tabpanels anymore,
the hide calls and listeners do nothing,
so we can drop them

Signed-off-by: Dominik Csapak <d.csapak at proxmox.com>
---
 www/manager6/ceph/Disks.js        | 1 -
 www/manager6/ceph/Monitor.js      | 1 -
 www/manager6/ceph/Pool.js         | 1 -
 www/manager6/ceph/Status.js       | 1 -
 www/manager6/dc/Summary.js        | 4 ----
 www/manager6/dc/Tasks.js          | 1 -
 www/manager6/ha/StatusView.js     | 1 -
 www/manager6/lxc/SnapshotTree.js  | 1 -
 www/manager6/lxc/Summary.js       | 1 -
 www/manager6/node/DNSView.js      | 1 -
 www/manager6/node/ServiceView.js  | 1 -
 www/manager6/node/Summary.js      | 1 -
 www/manager6/node/TimeView.js     | 1 -
 www/manager6/pool/Summary.js      | 1 -
 www/manager6/qemu/HardwareView.js | 1 -
 www/manager6/qemu/Options.js      | 1 -
 www/manager6/qemu/SnapshotTree.js | 1 -
 www/manager6/qemu/Summary.js      | 1 -
 www/manager6/storage/Summary.js   | 1 -
 19 files changed, 22 deletions(-)

diff --git a/www/manager6/ceph/Disks.js b/www/manager6/ceph/Disks.js
index 47b08bd..b016788 100644
--- a/www/manager6/ceph/Disks.js
+++ b/www/manager6/ceph/Disks.js
@@ -105,7 +105,6 @@ Ext.define('PVE.node.CephDiskList', {
 
 	    listeners: {
 		activate: rstore.startUpdate,
-		hide: rstore.stopUpdate,
 		destroy: rstore.stopUpdate
 	    }
 	});
diff --git a/www/manager6/ceph/Monitor.js b/www/manager6/ceph/Monitor.js
index acfd2cc..1c8b6cf 100644
--- a/www/manager6/ceph/Monitor.js
+++ b/www/manager6/ceph/Monitor.js
@@ -190,7 +190,6 @@ Ext.define('PVE.node.CephMonList', {
 	    ],
 	    listeners: {
 		activate: rstore.startUpdate,
-		hide: rstore.stopUpdate,
 		destroy: rstore.stopUpdate
 	    }
 	});
diff --git a/www/manager6/ceph/Pool.js b/www/manager6/ceph/Pool.js
index 9f203e3..8aaf5c9 100644
--- a/www/manager6/ceph/Pool.js
+++ b/www/manager6/ceph/Pool.js
@@ -198,7 +198,6 @@ Ext.define('PVE.node.CephPoolList', {
 	    tbar: [ create_btn, remove_btn ],
 	    listeners: {
 		activate: rstore.startUpdate,
-		hide: rstore.stopUpdate,
 		destroy: rstore.stopUpdate
 	    }
 	});
diff --git a/www/manager6/ceph/Status.js b/www/manager6/ceph/Status.js
index 495bd42..171cc2a 100644
--- a/www/manager6/ceph/Status.js
+++ b/www/manager6/ceph/Status.js
@@ -122,7 +122,6 @@ Ext.define('PVE.node.CephStatus', {
 	me.callParent();
 
 	me.on('activate', me.rstore.startUpdate);
-	me.on('hide', me.rstore.stopUpdate);
 	me.on('destroy', me.rstore.stopUpdate);
     }
 });
diff --git a/www/manager6/dc/Summary.js b/www/manager6/dc/Summary.js
index fae8e36..11d6ba0 100644
--- a/www/manager6/dc/Summary.js
+++ b/www/manager6/dc/Summary.js
@@ -69,7 +69,6 @@ Ext.define('PVE.dc.NodeView', {
 	    ],
 	    listeners: {
 		show: rstore.startUpdate,
-		hide: rstore.stopUpdate,
 		destroy: rstore.stopUpdate
 	    }
 	});
@@ -130,9 +129,6 @@ Ext.define('PVE.dc.Summary', {
 	    listeners: {
 		activate: function() {
 		    nodegrid.fireEvent('show', nodegrid);
-		},
-		hide: function() {
-		    nodegrid.fireEvent('hide', nodegrid);
 		}
 	    }
 	});
diff --git a/www/manager6/dc/Tasks.js b/www/manager6/dc/Tasks.js
index 58d09a5..ad9a22c 100644
--- a/www/manager6/dc/Tasks.js
+++ b/www/manager6/dc/Tasks.js
@@ -131,7 +131,6 @@ Ext.define('PVE.dc.Tasks', {
 	    listeners: {
 		itemdblclick: run_task_viewer,
 		show: taskstore.startUpdate,
-		hide: taskstore.stopUpdate,
 		destroy: taskstore.stopUpdate
 	    }
 	});
diff --git a/www/manager6/ha/StatusView.js b/www/manager6/ha/StatusView.js
index a69b34c..1032fab 100644
--- a/www/manager6/ha/StatusView.js
+++ b/www/manager6/ha/StatusView.js
@@ -61,7 +61,6 @@ Ext.define('PVE.ha.StatusView', {
 	me.callParent();
 
 	me.on('activate', me.rstore.startUpdate);
-	me.on('hide', me.rstore.stopUpdate);
 	me.on('destroy', me.rstore.stopUpdate);	
 
     }
diff --git a/www/manager6/lxc/SnapshotTree.js b/www/manager6/lxc/SnapshotTree.js
index 33a560d..1164495 100644
--- a/www/manager6/lxc/SnapshotTree.js
+++ b/www/manager6/lxc/SnapshotTree.js
@@ -290,7 +290,6 @@ Ext.define('PVE.lxc.SnapshotTree', {
 	    columnLines: true,
 	    listeners: {
 		activate: me.reload,
-		hide: me.load_task.cancel,
 		destroy: me.load_task.cancel,
 		itemdblclick: run_editor
 	    }
diff --git a/www/manager6/lxc/Summary.js b/www/manager6/lxc/Summary.js
index f93f5f7..8d14c94 100644
--- a/www/manager6/lxc/Summary.js
+++ b/www/manager6/lxc/Summary.js
@@ -142,7 +142,6 @@ Ext.define('PVE.lxc.Summary', {
 		},
 		listeners: {
 		    activate: function() { notesview.load(); rrdstore.startUpdate(); },
-		    hide: rrdstore.stopUpdate,
 		    destroy: rrdstore.stopUpdate
 		}
 	    });
diff --git a/www/manager6/node/DNSView.js b/www/manager6/node/DNSView.js
index 9eacdc7..07c479b 100644
--- a/www/manager6/node/DNSView.js
+++ b/www/manager6/node/DNSView.js
@@ -41,7 +41,6 @@ Ext.define('PVE.node.DNSView', {
 	me.callParent();
 
 	me.on('activate', me.rstore.startUpdate);
-	me.on('hide', me.rstore.stopUpdate);
 	me.on('destroy', me.rstore.stopUpdate);	
     }
 });
diff --git a/www/manager6/node/ServiceView.js b/www/manager6/node/ServiceView.js
index dab9893..c183748 100644
--- a/www/manager6/node/ServiceView.js
+++ b/www/manager6/node/ServiceView.js
@@ -145,7 +145,6 @@ Ext.define('PVE.node.ServiceView', {
 	    listeners: {
 		selectionchange: set_button_status,
 		activate: rstore.startUpdate,
-		hide: rstore.stopUpdate,
 		destroy: rstore.stopUpdate
 	    }
 	});
diff --git a/www/manager6/node/Summary.js b/www/manager6/node/Summary.js
index 1231796..92e0551 100644
--- a/www/manager6/node/Summary.js
+++ b/www/manager6/node/Summary.js
@@ -142,7 +142,6 @@ Ext.define('PVE.node.Summary', {
 	    },
 	    listeners: {
 		activate: function() { rstore.startUpdate(); rrdstore.startUpdate(); },
-		hide: function() { rstore.stopUpdate(); rrdstore.stopUpdate(); },
 		destroy: function() { rstore.stopUpdate(); rrdstore.stopUpdate(); }
 	    }
 	});
diff --git a/www/manager6/node/TimeView.js b/www/manager6/node/TimeView.js
index f706f11..20c8310 100644
--- a/www/manager6/node/TimeView.js
+++ b/www/manager6/node/TimeView.js
@@ -52,7 +52,6 @@ Ext.define('PVE.node.TimeView', {
 	me.callParent();
 
 	me.on('activate', me.rstore.startUpdate);
-	me.on('hide', me.rstore.stopUpdate);
 	me.on('destroy', me.rstore.stopUpdate);	
     }
 });
diff --git a/www/manager6/pool/Summary.js b/www/manager6/pool/Summary.js
index 97ae33e..47c0c7a 100644
--- a/www/manager6/pool/Summary.js
+++ b/www/manager6/pool/Summary.js
@@ -28,7 +28,6 @@ Ext.define('PVE.pool.Summary', {
 	});
 
 	me.on('activate', rstore.startUpdate);
-	me.on('hide', rstore.stopUpdate);
 	me.on('destroy', rstore.stopUpdate);	
 
 	me.callParent();
diff --git a/www/manager6/qemu/HardwareView.js b/www/manager6/qemu/HardwareView.js
index 5fe0410..3ed80ff 100644
--- a/www/manager6/qemu/HardwareView.js
+++ b/www/manager6/qemu/HardwareView.js
@@ -527,7 +527,6 @@ Ext.define('PVE.qemu.HardwareView', {
 	me.callParent();
 
 	me.on('activate', me.rstore.startUpdate);
-	me.on('hide', me.rstore.stopUpdate);
 	me.on('destroy', me.rstore.stopUpdate);	
 
 	me.mon(me.rstore, 'refresh', function() {
diff --git a/www/manager6/qemu/Options.js b/www/manager6/qemu/Options.js
index 9f2bd07..f60654d 100644
--- a/www/manager6/qemu/Options.js
+++ b/www/manager6/qemu/Options.js
@@ -402,7 +402,6 @@ Ext.define('PVE.qemu.Options', {
 	me.callParent();
 
 	me.on('activate', me.rstore.startUpdate);
-	me.on('hide', me.rstore.stopUpdate);
 	me.on('destroy', me.rstore.stopUpdate);	
 
 	me.rstore.on('datachanged', function() {
diff --git a/www/manager6/qemu/SnapshotTree.js b/www/manager6/qemu/SnapshotTree.js
index e580124..266ecf4 100644
--- a/www/manager6/qemu/SnapshotTree.js
+++ b/www/manager6/qemu/SnapshotTree.js
@@ -290,7 +290,6 @@ Ext.define('PVE.qemu.SnapshotTree', {
 	    columnLines: true, // will work in 4.1?
 	    listeners: {
 		activate: me.reload,
-		hide: me.load_task.cancel,
 		destroy: me.load_task.cancel,
 		itemdblclick: run_editor
 	    }
diff --git a/www/manager6/qemu/Summary.js b/www/manager6/qemu/Summary.js
index 64164fc..67b740a 100644
--- a/www/manager6/qemu/Summary.js
+++ b/www/manager6/qemu/Summary.js
@@ -146,7 +146,6 @@ Ext.define('PVE.qemu.Summary', {
 		},
 		listeners: {
 		    activate: function() {notesview.load(); rrdstore.startUpdate();},
-		    hide: rrdstore.stopUpdate,
 		    destroy: rrdstore.stopUpdate
 		}
 	    });
diff --git a/www/manager6/storage/Summary.js b/www/manager6/storage/Summary.js
index 43b1b02..7f0e4df 100644
--- a/www/manager6/storage/Summary.js
+++ b/www/manager6/storage/Summary.js
@@ -50,7 +50,6 @@ Ext.define('PVE.storage.Summary', {
 	    ],
 	    listeners: {
 		activate: function() { rstore.startUpdate(); rrdstore.startUpdate(); },
-		hide: function() { rstore.stopUpdate(); rrdstore.stopUpdate(); },
 		destroy: function() { rstore.stopUpdate(); rrdstore.stopUpdate(); }
 	    }
 	});
-- 
2.1.4





More information about the pve-devel mailing list