[pve-devel] [PATCH manager 1/2] refactor backupconfig window

[Dominik Csapak]

refactor it in its own class, because we need it again

Signed-off-by: Dominik Csapak <d.csapak at proxmox.com>
---
 www/manager6/Makefile               |  1 +
 www/manager6/grid/BackupView.js     | 36 +++-----------------------
 www/manager6/window/BackupConfig.js | 50 +++++++++++++++++++++++++++++++++++++
 3 files changed, 55 insertions(+), 32 deletions(-)
 create mode 100644 www/manager6/window/BackupConfig.js

diff --git a/www/manager6/Makefile b/www/manager6/Makefile
index 41c564f..d76342d 100644
--- a/www/manager6/Makefile
+++ b/www/manager6/Makefile
@@ -85,6 +85,7 @@ JSSRC= 				                 	\
 	window/Backup.js				\
 	window/Restore.js				\
 	window/SafeDestroy.js				\
+	window/BackupConfig.js				\
 	panel/NotesView.js				\
 	grid/SelectFeature.js				\
 	grid/ObjectGrid.js				\
diff --git a/www/manager6/grid/BackupView.js b/www/manager6/grid/BackupView.js
index cc654bc..2f67337 100644
--- a/www/manager6/grid/BackupView.js
+++ b/www/manager6/grid/BackupView.js
@@ -187,40 +187,12 @@ Ext.define('PVE.grid.BackupView', {
 		    return;
 		}
 
-		var win = Ext.create('Ext.window.Window', {
-		    title: gettext('Configuration'),
-		    width: 600,
-		    height: 400,
-		    layout: 'fit',
-		    modal: true,
-		    items: [{
-			xtype: 'component',
-			itemId: 'configtext',
-			autoScroll: true,
-			style: {
-			    'background-color': 'white',
-			    'white-space': 'pre',
-			    'font-family': 'monospace',
-			    padding: '5px'
-			}
-		    }]
+		var win = Ext.create('PVE.window.BackupConfig', {
+		    volume: rec.data.volid,
+		    pveSelNode: me.pveSelNode
 		});
 
-		PVE.Utils.API2Request({
-		    url: "/nodes/" + nodename + "/vzdump/extractconfig",
-		    method: 'GET',
-		    params: {
-			volume: rec.data.volid
-		    },
-		    failure: function(response, opts) {
-			win.close();
-			Ext.Msg.alert('Error', response.htmlStatus);
-		    },
-		    success: function(response,options) {
-			win.show();
-			win.down('#configtext').update(Ext.htmlEncode(response.result.data));
-		    }
-		});
+		win.show();
 	    }
 	});
 
diff --git a/www/manager6/window/BackupConfig.js b/www/manager6/window/BackupConfig.js
new file mode 100644
index 0000000..8b0fd04
--- /dev/null
+++ b/www/manager6/window/BackupConfig.js
@@ -0,0 +1,50 @@
+Ext.define('PVE.window.BackupConfig', {
+    extend: 'Ext.window.Window',
+    title: gettext('Configuration'),
+    width: 600,
+    height: 400,
+    layout: 'fit',
+    modal: true,
+    items: {
+	xtype: 'component',
+	itemId: 'configtext',
+	autoScroll: true,
+	style: {
+	    'background-color': 'white',
+	    'white-space': 'pre',
+	    'font-family': 'monospace',
+	    padding: '5px'
+	}
+    },
+
+    initComponent: function() {
+	var me = this;
+
+	if (!me.volume) {
+	    throw "no volume specified";
+	}
+
+	var nodename = me.pveSelNode.data.node;
+	if (!nodename) {
+	    throw "no node name specified";
+	}
+
+	me.callParent();
+
+	PVE.Utils.API2Request({
+	    url: "/nodes/" + nodename + "/vzdump/extractconfig",
+	    method: 'GET',
+	    params: {
+		volume: me.volume
+	    },
+	    failure: function(response, opts) {
+		me.close();
+		Ext.Msg.alert('Error', response.htmlStatus);
+	    },
+	    success: function(response,options) {
+		me.show();
+		me.down('#configtext').update(Ext.htmlEncode(response.result.data));
+	    }
+	});
+    }
+});
-- 
2.1.4