[pve-devel] [PATCH ovs 1/2] remove openvswitch-switch init script

[Alexandre DERUMIER]

Hi,

I have tested the patch, and It's working fine for me !


----- Mail original -----
De: "aderumier" <aderumier at odiso.com>
À: "Fabian Grünbichler" <f.gruenbichler at proxmox.com>
Cc: "pve-devel" <pve-devel at pve.proxmox.com>
Envoyé: Vendredi 26 Août 2016 13:08:08
Objet: Re: [pve-devel] [PATCH ovs 1/2] remove openvswitch-switch init script

Ok, great ! 

>>If you have a test or real setup that does not work without the init 
>>script, please give details! 

I'll try to do test again next week, my last test was 1year ago 

----- Mail original ----- 
De: "Fabian Grünbichler" <f.gruenbichler at proxmox.com> 
À: "pve-devel" <pve-devel at pve.proxmox.com> 
Cc: "aderumier" <aderumier at odiso.com> 
Envoyé: Vendredi 26 Août 2016 13:01:27 
Objet: Re: [pve-devel] [PATCH ovs 1/2] remove openvswitch-switch init script 

On Fri, Aug 26, 2016 at 12:41:42PM +0200, Alexandre DERUMIER wrote: 
> Are you sure that systemd manage correctly this part: 
> 
> +-network_interfaces () { 
> +- INTERFACES="/etc/network/interfaces" 
> +- [ -e "${INTERFACES}" ] || return 
> +- bridges=`ifquery --allow ovs --list` 
> +- [ -n "${bridges}" ] && $1 --allow=ovs ${bridges} 
> +-} 
> 
> 
> ? 
> 
> If I remember, the have keep the init script for this. 
> I think the systemd unit only manage config from ovs database, but not debian /etc/network/interfaces 

I tested it with a (OVS) bridge and intport defined in 
/etc/network/interfaces, both are brought up without the init script 
without any problems. 

There are pre-up and post-down snippets installed in /etc/network/.. 
which should handle calling ovs binaries to add/remove the interfaces 
defined in /etc/network/interfaces. 

If you have a test or real setup that does not work without the init 
script, please give details! 

_______________________________________________ 
pve-devel mailing list 
pve-devel at pve.proxmox.com 
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel