[pve-devel] [PATCH container 1/3] Fix #791: warn when resize2fs fails

Dietmar Maurer dietmar at proxmox.com
Fri Feb 5 09:53:59 CET 2016


>  		    } else {
> -			PVE::Tools::run_command(['e2fsck', '-f', '-y', $path]);
> -			PVE::Tools::run_command(['resize2fs', $path]);
> +			eval {
> +			    PVE::Tools::run_command(['e2fsck', '-f', '-y', $path]);
> +			    PVE::Tools::run_command(['resize2fs', $path]);
> +			};
>  		    }
> +		    warn "Failed to update the container's filesystem: $@\n";

looks strange to me - what if there is no error ($@ can be undefined)?




More information about the pve-devel mailing list