[pve-devel] [PATCH storage] zfs: get the real mountpoint in path()

Wolfgang Bumiller w.bumiller at proxmox.com
Fri Feb 12 17:00:16 CET 2016


> On February 12, 2016 at 4:39 PM Dietmar Maurer <dietmar at proxmox.com> wrote:
> 
> 
> > > Since mountpoints can be inherited and modified (and set to 'legacy'
> > > and 'none') we need to deal with this. The current method of assuming
> > > default paths doesn't always work.
> > 
> > Can't we make this a requirement instead (document and verify somehow)?
> 
> For example, we could verify that it is correctly mounted
> in the storage activate method?

Verify: yes, but we can't really "mount" them as we'd also have to
make sure we mount all the intermediate paths because otherwise you're
guaranteed to end up with zfs complaining about non-empty directories
at some point.
(Well, we COULD do that but I'd rather just
`die "fix your silly zfs option nonsense\n";`)

I'd still like to support the 'legacy' case though as I personally
see no point in having all the subvolumes mounted on the host for
no reason. (I mean, that only happens with ZFS after all.)
(That would even be a much nicer default...)




More information about the pve-devel mailing list