[pve-devel] [PATCH container 0/4] snapshot rollback tests and fixes

Fabian Grünbichler f.gruenbichler at proxmox.com
Tue Feb 23 15:00:10 CET 2016


This patch series introduces one fix in the LXC snapshot rollback
code, namely using run_command() to call lxc-stop --kill instead of
using system() directly.

It also cleans up the existing snapshot test code and extends it
to also test snapshot_rollback().

Fabian Grünbichler (4):
  Add '\n' to die statements
  Use run_command instead of system to stop CT
  Cleanup test output
  Add snapshot rollback testcases

 src/PVE/LXC.pm                                   |   5 +-
 src/test/snapshot-expected/rollback/lxc/101.conf |  25 +++
 src/test/snapshot-expected/rollback/lxc/102.conf |  38 ++++
 src/test/snapshot-expected/rollback/lxc/103.conf |  39 ++++
 src/test/snapshot-expected/rollback/lxc/104.conf |  51 +++++
 src/test/snapshot-expected/rollback/lxc/201.conf |  23 +++
 src/test/snapshot-expected/rollback/lxc/202.conf |  23 +++
 src/test/snapshot-expected/rollback/lxc/203.conf |  24 +++
 src/test/snapshot-expected/rollback/lxc/204.conf |  24 +++
 src/test/snapshot-expected/rollback/lxc/205.conf |  24 +++
 src/test/snapshot-expected/rollback/lxc/206.conf |  23 +++
 src/test/snapshot-input/rollback/lxc/101.conf    |  25 +++
 src/test/snapshot-input/rollback/lxc/102.conf    |  38 ++++
 src/test/snapshot-input/rollback/lxc/103.conf    |  39 ++++
 src/test/snapshot-input/rollback/lxc/104.conf    |  51 +++++
 src/test/snapshot-input/rollback/lxc/201.conf    |  23 +++
 src/test/snapshot-input/rollback/lxc/202.conf    |  23 +++
 src/test/snapshot-input/rollback/lxc/203.conf    |  24 +++
 src/test/snapshot-input/rollback/lxc/204.conf    |  24 +++
 src/test/snapshot-input/rollback/lxc/205.conf    |  24 +++
 src/test/snapshot-input/rollback/lxc/206.conf    |  23 +++
 src/test/snapshot-test.pm                        | 229 +++++++++++++++++------
 22 files changed, 758 insertions(+), 64 deletions(-)
 create mode 100644 src/test/snapshot-expected/rollback/lxc/101.conf
 create mode 100644 src/test/snapshot-expected/rollback/lxc/102.conf
 create mode 100644 src/test/snapshot-expected/rollback/lxc/103.conf
 create mode 100644 src/test/snapshot-expected/rollback/lxc/104.conf
 create mode 100644 src/test/snapshot-expected/rollback/lxc/201.conf
 create mode 100644 src/test/snapshot-expected/rollback/lxc/202.conf
 create mode 100644 src/test/snapshot-expected/rollback/lxc/203.conf
 create mode 100644 src/test/snapshot-expected/rollback/lxc/204.conf
 create mode 100644 src/test/snapshot-expected/rollback/lxc/205.conf
 create mode 100644 src/test/snapshot-expected/rollback/lxc/206.conf
 create mode 100644 src/test/snapshot-input/rollback/lxc/101.conf
 create mode 100644 src/test/snapshot-input/rollback/lxc/102.conf
 create mode 100644 src/test/snapshot-input/rollback/lxc/103.conf
 create mode 100644 src/test/snapshot-input/rollback/lxc/104.conf
 create mode 100644 src/test/snapshot-input/rollback/lxc/201.conf
 create mode 100644 src/test/snapshot-input/rollback/lxc/202.conf
 create mode 100644 src/test/snapshot-input/rollback/lxc/203.conf
 create mode 100644 src/test/snapshot-input/rollback/lxc/204.conf
 create mode 100644 src/test/snapshot-input/rollback/lxc/205.conf
 create mode 100644 src/test/snapshot-input/rollback/lxc/206.conf

-- 
2.1.4





More information about the pve-devel mailing list