[pve-devel] [PATCH pve-manager 2/2] Revert "ext5migrate: do not set a custome idProperty for the KeyValue model"

Emmanuel Kasper e.kasper at proxmox.com
Wed Feb 24 10:53:52 CET 2016


This reverts commit 3150236aa5ebed6565c6eaf64126bb1195693396.

Without using an idProperty in the KeyValue model, the id of each
store item is autogenerated, and the DiffStore always recreate the whole
store content every second instead of updating the fields where values
have changed. Recreating the whole store content makes the
Node Summary View flicker, as the order of items in the store change
after each reload.

Testing shows that reversing this commit do not break anything else.
---
 www/manager6/data/PVEProxy.js | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/www/manager6/data/PVEProxy.js b/www/manager6/data/PVEProxy.js
index 01c20cb..20c1acb 100644
--- a/www/manager6/data/PVEProxy.js
+++ b/www/manager6/data/PVEProxy.js
@@ -61,7 +61,8 @@ Ext.define('PVE.RestProxy', {
 
     Ext.define('KeyValue', {
 	extend: "Ext.data.Model",
-	fields: [ 'key', 'value' ]
+	fields: [ 'key', 'value' ],
+	idProperty: 'key'
     });
 
     Ext.define('KeyValuePendingDelete', {
-- 
2.1.4





More information about the pve-devel mailing list