[pve-devel] [PATCH pve-manager 1/4] move tabs of a sub tabpanel to the left by default

Emmanuel Kasper e.kasper at proxmox.com
Mon Feb 29 13:50:08 CET 2016


This takes a bit of screensize, but is fine as long as the browser
horizontal screen size is at least 1280 px ( 92 % of desktop users in 2016
according to StatsCounter)
Still usable for the remaining small displays, but horizontal scrolling
is needed for grids with a lot of columns.

Moving the sub tabs to the top left provides a minor usability
improvement as all controls are now grouped together in the same
screen region.
---
 www/manager6/panel/SubConfigPanel.js | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/www/manager6/panel/SubConfigPanel.js b/www/manager6/panel/SubConfigPanel.js
index 849fd04..e0a7619 100644
--- a/www/manager6/panel/SubConfigPanel.js
+++ b/www/manager6/panel/SubConfigPanel.js
@@ -3,6 +3,8 @@ Ext.define('PVE.panel.SubConfig', {
     alias: ['widget.pvePanelSubConfig'],
 
     configPrefix: undefined,
+    tabPosition: 'left',
+    tabRotation: 0,
 
     getHState: function(itemId) {
 	 /*jslint confusion: true */
@@ -45,8 +47,6 @@ Ext.define('PVE.panel.SubConfig', {
 	}
 
 	Ext.apply(me, {
-	    plain: true,
-	    tabPosition: 'bottom',
 	    listeners: {
 		afterrender: function(tp) {
 		    var first =  tp.items.get(0);
-- 
2.1.4





More information about the pve-devel mailing list