[pve-devel] [PATCH pve-manager 1/2] ext6migrate: remove 'comment' id from Comment column in our tables

Emmanuel Kasper e.kasper at proxmox.com
Thu Jan 28 10:59:25 CET 2016


The use of this field raise an error with ExtJS6 because it is not
unique inside the application.
Removing this is safe, because we never query the Comment column
with an id.
---
 www/manager6/dc/AuthView.js       | 1 -
 www/manager6/dc/UserView.js       | 1 -
 www/manager6/form/PoolSelector.js | 1 -
 www/manager6/form/UserSelector.js | 1 -
 4 files changed, 4 deletions(-)

diff --git a/www/manager6/dc/AuthView.js b/www/manager6/dc/AuthView.js
index 0ff87b2..dde2139 100644
--- a/www/manager6/dc/AuthView.js
+++ b/www/manager6/dc/AuthView.js
@@ -128,7 +128,6 @@ Ext.define('PVE.dc.AuthView', {
 		    dataIndex: 'tfa'
 		},
 		{
-		    id: 'comment',
 		    header: gettext('Comment'),
 		    sortable: false,
 		    dataIndex: 'comment',
diff --git a/www/manager6/dc/UserView.js b/www/manager6/dc/UserView.js
index 1fc3567..41c3e81 100644
--- a/www/manager6/dc/UserView.js
+++ b/www/manager6/dc/UserView.js
@@ -217,7 +217,6 @@ Ext.define('PVE.dc.UserView', {
 		    dataIndex: 'firstname'
 		},
 		{
-		    id: 'comment',
 		    header: gettext('Comment'),
 		    sortable: false,
 		    dataIndex: 'comment',
diff --git a/www/manager6/form/PoolSelector.js b/www/manager6/form/PoolSelector.js
index a607589..912b43c 100644
--- a/www/manager6/form/PoolSelector.js
+++ b/www/manager6/form/PoolSelector.js
@@ -25,7 +25,6 @@ Ext.define('PVE.form.PoolSelector', {
 			flex: 1
 		    },
 		    {
-			id: 'comment',
 			header: gettext('Comment'),
 			sortable: false,
 			dataIndex: 'comment',
diff --git a/www/manager6/form/UserSelector.js b/www/manager6/form/UserSelector.js
index 3ba4d1b..f82431c 100644
--- a/www/manager6/form/UserSelector.js
+++ b/www/manager6/form/UserSelector.js
@@ -38,7 +38,6 @@ Ext.define('PVE.form.UserSelector', {
 			flex: 1
 		    },
 		    {
-			id: 'comment',
 			header: gettext('Comment'),
 			sortable: false,
 			dataIndex: 'comment',
-- 
2.1.4





More information about the pve-devel mailing list