[pve-devel] [PATCH v4 1/3] migrate: collect migration tunnel child process

Thomas Lamprecht t.lamprecht at proxmox.com
Thu Jun 2 19:05:55 CEST 2016



Am 02.06.2016 um 18:37 schrieb Dietmar Maurer:
>>
>>      if ($timeout) {
>>         for (my $i = 0; $i < $timeout; $i++) {
>> -           return if !PVE::ProcFSTools::check_process_running($cpid);
>> +           return if !&$check_process_running();
> 
> Maybe it is worth to include that waitpid 
> in PVE::ProcFSTools::check_process_running() - not sure...
> 

maybe with a parameter? But as someone can only call wait for there one
children and check_process_running is for all this may be not suited best.

Oh, and thanks for the solution in the other answer, that seems nice.
(And while I see your point I would not call mine serious drawback as it
was only used once and hardcoded to 30, just drawback :) )



More information about the pve-devel mailing list