[pve-devel] [PATCH] fix raise_param_exc in PVE::QemuServer::Memory::memory_unplug

Alexandre DERUMIER aderumier at odiso.com
Wed Jun 8 13:59:45 CEST 2016


>>This looks wrong to me. I thought that is defined in PVE::Exception? 

oj yes, sorry

It's simply missing

use PVE::Exception qw(raise raise_param_exc);

I'll resend a patch

----- Mail original -----
De: "dietmar" <dietmar at proxmox.com>
À: "aderumier" <aderumier at odiso.com>, "pve-devel" <pve-devel at pve.proxmox.com>
Envoyé: Mercredi 8 Juin 2016 12:51:36
Objet: Re: [pve-devel] [PATCH] fix raise_param_exc in PVE::QemuServer::Memory::memory_unplug

This looks wrong to me. I thought that is defined in PVE::Exception? 

> On June 8, 2016 at 11:10 AM Alexandre Derumier <aderumier at odiso.com> wrote: 
> 
> 
> Signed-off-by: Alexandre Derumier <aderumier at odiso.com> 
> --- 
> PVE/QemuServer/Memory.pm | 2 +- 
> 1 file changed, 1 insertion(+), 1 deletion(-) 
> 
> diff --git a/PVE/QemuServer/Memory.pm b/PVE/QemuServer/Memory.pm 
> index 376beb9..3cfd487 100644 
> --- a/PVE/QemuServer/Memory.pm 
> +++ b/PVE/QemuServer/Memory.pm 
> @@ -106,7 +106,7 @@ sub qemu_memory_hotplug { 
> sleep 3; 
> my $dimm_list = qemu_dimm_list($vmid); 
> last if !$dimm_list->{$name}; 
> - raise_param_exc({ $name => "error unplug memory module" }) if $retry > 
> 5; 
> + PVE::QemuServer::raise_param_exc({ $name => "error unplug memory 
> module" }) if $retry > 5; 
> pve-devel mailing list 
> pve-devel at pve.proxmox.com 
> http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel 
> 


More information about the pve-devel mailing list