[pve-devel] [PATCH] fix raise_param_exc in PVE::QemuServer::Memory::memory_unplug

Alexandre DERUMIER aderumier at odiso.com
Wed Jun 8 18:41:37 CEST 2016


>>Sigh, and we also have a cyclic include: 
>>
>>PVE::QemuServer => PVE::QemuServer::Memory => PVE::QemuServer 

Is it really a problem ? (you are better than me with Perl)


>>and ideas how to avoid that? 

Here the list of sub from QemuServer.pm used in QemuServer::Memory

PVE::QemuServer::vm_mon_cmd
PVE::QemuServer::qemu_objectdel
PVE::QemuServer::qemu_devicedel
PVE::QemuServer::vm_mon_cmd_nocheck

-> could be move in a new QemuServer::Commands  for example

PVE::QemuServer::parse_hotplug_features

-> could be move in a new QemuServer::Config  for example

----- Mail original -----
De: "dietmar" <dietmar at proxmox.com>
À: "aderumier" <aderumier at odiso.com>, "pve-devel" <pve-devel at pve.proxmox.com>
Envoyé: Mercredi 8 Juin 2016 13:28:24
Objet: Re: [pve-devel] [PATCH] fix raise_param_exc in PVE::QemuServer::Memory::memory_unplug

> On June 8, 2016 at 12:51 PM Dietmar Maurer <dietmar at proxmox.com> wrote: 
> 
> 
> This looks wrong to me. I thought that is defined in PVE::Exception? 

Sigh, and we also have a cyclic include: 

PVE::QemuServer => PVE::QemuServer::Memory => PVE::QemuServer 

and ideas how to avoid that? 


More information about the pve-devel mailing list