[pve-devel] [PATCH] fix raise_param_exc in PVE::QemuServer::Memory::memory_unplug

Alexandre DERUMIER aderumier at odiso.com
Wed Jun 8 19:37:22 CEST 2016


>>Yes, something like that. 

Ok, I'll try to improve this.

(Could we finish hugepages support before that ? )


----- Mail original -----
De: "dietmar" <dietmar at proxmox.com>
À: "aderumier" <aderumier at odiso.com>
Cc: "pve-devel" <pve-devel at pve.proxmox.com>
Envoyé: Mercredi 8 Juin 2016 18:55:33
Objet: Re: [pve-devel] [PATCH] fix raise_param_exc in PVE::QemuServer::Memory::memory_unplug

> >>Sigh, and we also have a cyclic include: 
> >> 
> >>PVE::QemuServer => PVE::QemuServer::Memory => PVE::QemuServer 
> 
> Is it really a problem ? (you are better than me with Perl) 

No, it is no 'real' problem. But it is not nice, and I think 
we should try to avoid it. 

> >>and ideas how to avoid that? 
> 
> Here the list of sub from QemuServer.pm used in QemuServer::Memory 
> 
> PVE::QemuServer::vm_mon_cmd 
> PVE::QemuServer::qemu_objectdel 
> PVE::QemuServer::qemu_devicedel 
> PVE::QemuServer::vm_mon_cmd_nocheck 
> 
> -> could be move in a new QemuServer::Commands for example 
> 
> PVE::QemuServer::parse_hotplug_features 
> 
> -> could be move in a new QemuServer::Config for example 

Yes, something like that. 



More information about the pve-devel mailing list