[pve-devel] [PATCH] fix use as source source

Dietmar Maurer dietmar at proxmox.com
Tue Jun 14 12:31:06 CEST 2016


The commit message looks strange (source source?)

> On June 14, 2016 at 11:30 AM Wolfgang Link <w.link at proxmox.com> wrote:
> 
> 
> ---
>  pve-zsync | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/pve-zsync b/pve-zsync
> index ff9ee8f..b0abf3c 100644
> --- a/pve-zsync
> +++ b/pve-zsync
> @@ -476,7 +476,7 @@ sub init {
>  
>      die "Pool $dest->{all} does not exists\n" if check_pool_exists($dest);
>  
> -    my $check = check_pool_exists($source->{path}, $source->{ip}) if
> !$source->{vmid} && $source->{path};
> +    my $check = check_pool_exists($source) if !$source->{vmid} &&
> $source->{path};
>  
>      die "Pool $source->{path} does not exists\n" if undef($check);

I would prefer "if !defined($check);" here (avoid side effects).  



>  
> -- 
> 2.1.4
> 
> 
> _______________________________________________
> pve-devel mailing list
> pve-devel at pve.proxmox.com
> http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
> 



More information about the pve-devel mailing list