[pve-devel] [PATCH manager 08/10] ext6migrate: fix ContentView grouping

Dominik Csapak d.csapak at proxmox.com
Thu Mar 10 11:47:00 CET 2016


the framework triggers the convert function
when you click on a grouping header

since there is no volid there, we have to check this,
otherwise we get an error

Signed-off-by: Dominik Csapak <d.csapak at proxmox.com>
---
 www/manager6/storage/ContentView.js | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/www/manager6/storage/ContentView.js b/www/manager6/storage/ContentView.js
index c0edf81..c6df0b8 100644
--- a/www/manager6/storage/ContentView.js
+++ b/www/manager6/storage/ContentView.js
@@ -505,7 +505,9 @@ Ext.define('PVE.storage.ContentView', {
 	    {	
 		name: 'text', 
 		convert: function(value, record) {
-		    if (value) {
+		    // check for volid, because if you click on a grouping header,
+		    // it calls convert (but with an empty volid)
+		    if (value || record.data.volid === null) {
 			return value;
 		    }
 		    return PVE.Utils.render_storage_content(value, {}, record);
-- 
2.1.4





More information about the pve-devel mailing list