[pve-devel] [PATCH manager v2] fix compression selection in backup window

Dominik Csapak d.csapak at proxmox.com
Thu Mar 31 14:45:10 CEST 2016


we wrongly assumed, that no compression argument for
vzdump meant 'no compression', instead it means 'lzo'

this patch mirrors that behaviour on the gui

Signed-off-by: Dominik Csapak <d.csapak at proxmox.com>
---
changes since v1:
 send compression parameter even it is lzo
 always set field initially to lzo (if it exists, it will be overwritten)

 www/manager6/dc/Backup.js                | 2 +-
 www/manager6/form/CompressionSelector.js | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/www/manager6/dc/Backup.js b/www/manager6/dc/Backup.js
index 1a2a241..5b059b6 100644
--- a/www/manager6/dc/Backup.js
+++ b/www/manager6/dc/Backup.js
@@ -172,7 +172,7 @@ Ext.define('PVE.dc.BackupEdit', {
 		fieldLabel: gettext('Compression'),
 		name: 'compress',
 		deleteEmpty: me.create ? false : true,
-		value: me.create ? 'lzo' : ''
+		value: 'lzo'
 	    },
 	    {
 		xtype: 'pveBackupModeSelector',
diff --git a/www/manager6/form/CompressionSelector.js b/www/manager6/form/CompressionSelector.js
index 1a5299f..03669e0 100644
--- a/www/manager6/form/CompressionSelector.js
+++ b/www/manager6/form/CompressionSelector.js
@@ -2,7 +2,7 @@ Ext.define('PVE.form.CompressionSelector', {
     extend: 'PVE.form.KVComboBox',
     alias: ['widget.pveCompressionSelector'],
     comboItems: [
-                ['__default__', PVE.Utils.noneText],
+                ['0', PVE.Utils.noneText],
                 ['lzo', 'LZO (' + gettext('fast') + ')'],
                 ['gzip', 'GZIP (' + gettext('good') + ')']
     ]
-- 
2.1.4





More information about the pve-devel mailing list